create new vsc modification #420
Conversation
jamal-khey
force-pushed
the
jamalkhey/vsc-modification
branch
from
5ade272 to
ff2845a
Compare
implement apply for vscConverterStation and add tests create a specific test network for vsc modification implement modification for reactive limite attribut in hvdc line are set correctly Refactor VscModificationEntity and VscModificationTest Update VSC Modification and Converter Station Entities Update database changelog and entity class Add ConverterStationModificationInfos class and modify VscModificationInfos class Add MODIFY_CONVERTER_STATION_ERROR to NetworkModificationException class some attributes can be updated Update VscModificationEntity and VscModification classes progress , fixing some failing tests work in progress, tests are failing due to table does not existe Signed-off-by: jamal-khey <myjamal89@gmail.com>
jamal-khey
force-pushed
the
jamalkhey/vsc-modification
branch
from
908a57d to
856ce0c
Compare
Signed-off-by: jamal-khey <myjamal89@gmail.com>
jamal-khey
changed the title
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: jamal-khey <myjamal89@gmail.com>
jamal-khey
changed the title
| value.getQmaxP(), value.getOldQmaxP(), | ||
| value.getP(), value.getOldP())) | ||
| .toList() : null; | ||
| } |
There was a problem hiding this comment.
it can be done like this i think
public static List convertToReactiveCapabilityCurveModificationInfos(List rCCpoints) {
return CollectionUtils.isEmpty(rCCpoints) ? List.of() : rCCpoints
.stream()
.map(value -> new ReactiveCapabilityCurveModificationInfos(value.getQminP(), value.getOldQminP(),
value.getQmaxP(), value.getOldQmaxP(),
value.getP(), value.getOldP()))
.toList();
}
There was a problem hiding this comment.
done , i juste replaced 'List.of()' in your suggestion by 'null'
it can be done like this i think
| List<ReactiveCapabilityCurveModificationInfos> modificationPoints = converterStationModificationInfos.getReactiveCapabilityCurvePoints(); | ||
| if (modificationPoints != null) { | ||
| ModificationUtils.getInstance().checkMaxQGreaterThanMinQ(modificationPoints, MODIFY_BATTERY_ERROR, errorMessage); | ||
| } |
There was a problem hiding this comment.
this code block (line 39 -> 47) is repeated in GeneratorModification and BatteryModification. Maybe add a method in ModificationUtils and call it in the 3 classes
…tion and BatteryModification Signed-off-by: jamal-khey <myjamal89@gmail.com>
| import com.powsybl.iidm.network.ReactiveCapabilityCurveAdder; | ||
| import com.powsybl.iidm.network.ReactiveLimits; | ||
| import com.powsybl.iidm.network.ReactiveLimitsKind; | ||
| import com.powsybl.iidm.network.*; |
There was a problem hiding this comment.
maybe you shouldn't use wildcard
Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: jamal-khey <myjamal89@gmail.com>
fix logs in converter station Signed-off-by: jamal-khey <myjamal89@gmail.com>
Signed-off-by: jamal-khey <myjamal89@gmail.com>
|
No description provided.